forked from triton-lang/triton
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support FP8 conversions for CPU. #40
Merged
minjang
merged 6 commits into
triton-lang:main
from
ienkovich:ienkovich/cpu/dot-fp8-tf32
Jul 17, 2024
Merged
Support FP8 conversions for CPU. #40
minjang
merged 6 commits into
triton-lang:main
from
ienkovich:ienkovich/cpu/dot-fp8-tf32
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Enkovich <[email protected]>
Signed-off-by: Ilya Enkovich <[email protected]>
Signed-off-by: Ilya Enkovich <[email protected]>
Signed-off-by: Ilya Enkovich <[email protected]>
Signed-off-by: Ilya Enkovich <[email protected]>
5 tasks
minjang
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay as I was on ~2 week PTO!
Looks good. Seems a similar approach with the previous BF16 code.
Devjiu
pushed a commit
to Devjiu/triton-cpu
that referenced
this pull request
Aug 13, 2024
* Mark tests enabled on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Allow tf32 input for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add conversions for fp8 types on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add test_conversions.py to CI for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Fix formatting. Signed-off-by: Ilya Enkovich <[email protected]> --------- Signed-off-by: Ilya Enkovich <[email protected]> Co-authored-by: Minjang Kim <[email protected]>
int3
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Mark tests enabled on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Allow tf32 input for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add conversions for fp8 types on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add test_conversions.py to CI for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Fix formatting. Signed-off-by: Ilya Enkovich <[email protected]> --------- Signed-off-by: Ilya Enkovich <[email protected]> Co-authored-by: Minjang Kim <[email protected]>
minjang
added a commit
that referenced
this pull request
Sep 22, 2024
* Mark tests enabled on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Allow tf32 input for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add conversions for fp8 types on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add test_conversions.py to CI for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Fix formatting. Signed-off-by: Ilya Enkovich <[email protected]> --------- Signed-off-by: Ilya Enkovich <[email protected]> Co-authored-by: Minjang Kim <[email protected]>
minjang
added a commit
that referenced
this pull request
Oct 22, 2024
* Mark tests enabled on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Allow tf32 input for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add conversions for fp8 types on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add test_conversions.py to CI for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Fix formatting. Signed-off-by: Ilya Enkovich <[email protected]> --------- Signed-off-by: Ilya Enkovich <[email protected]> Co-authored-by: Minjang Kim <[email protected]>
minjang
added a commit
that referenced
this pull request
Oct 24, 2024
* Mark tests enabled on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Allow tf32 input for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add conversions for fp8 types on CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Add test_conversions.py to CI for CPU. Signed-off-by: Ilya Enkovich <[email protected]> * Fix formatting. Signed-off-by: Ilya Enkovich <[email protected]> --------- Signed-off-by: Ilya Enkovich <[email protected]> Co-authored-by: Minjang Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FP8 conversions so that we can run appropriate tests. Efficient conversions are used only in a couple of cases, others follow a generic emulation similar to the one used in conversion tests.