Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FP8 conversions for CPU. #40

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

ienkovich
Copy link
Collaborator

This PR adds FP8 conversions so that we can run appropriate tests. Efficient conversions are used only in a couple of cases, others follow a generic emulation similar to the one used in conversion tests.

@ienkovich ienkovich requested a review from minjang July 3, 2024 15:12
@ienkovich ienkovich requested a review from ptillet as a code owner July 3, 2024 15:12
Signed-off-by: Ilya Enkovich <[email protected]>
Copy link
Collaborator

@minjang minjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay as I was on ~2 week PTO!

Looks good. Seems a similar approach with the previous BF16 code.

@minjang minjang merged commit 5446b3f into triton-lang:main Jul 17, 2024
2 checks passed
@ienkovich ienkovich deleted the ienkovich/cpu/dot-fp8-tf32 branch July 17, 2024 21:28
Devjiu pushed a commit to Devjiu/triton-cpu that referenced this pull request Aug 13, 2024
* Mark tests enabled on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Allow tf32 input for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add conversions for fp8 types on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add test_conversions.py to CI for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Fix formatting.

Signed-off-by: Ilya Enkovich <[email protected]>

---------

Signed-off-by: Ilya Enkovich <[email protected]>
Co-authored-by: Minjang Kim <[email protected]>
int3 pushed a commit that referenced this pull request Aug 29, 2024
* Mark tests enabled on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Allow tf32 input for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add conversions for fp8 types on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add test_conversions.py to CI for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Fix formatting.

Signed-off-by: Ilya Enkovich <[email protected]>

---------

Signed-off-by: Ilya Enkovich <[email protected]>
Co-authored-by: Minjang Kim <[email protected]>
minjang added a commit that referenced this pull request Sep 22, 2024
* Mark tests enabled on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Allow tf32 input for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add conversions for fp8 types on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add test_conversions.py to CI for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Fix formatting.

Signed-off-by: Ilya Enkovich <[email protected]>

---------

Signed-off-by: Ilya Enkovich <[email protected]>
Co-authored-by: Minjang Kim <[email protected]>
minjang added a commit that referenced this pull request Oct 22, 2024
* Mark tests enabled on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Allow tf32 input for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add conversions for fp8 types on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add test_conversions.py to CI for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Fix formatting.

Signed-off-by: Ilya Enkovich <[email protected]>

---------

Signed-off-by: Ilya Enkovich <[email protected]>
Co-authored-by: Minjang Kim <[email protected]>
minjang added a commit that referenced this pull request Oct 24, 2024
* Mark tests enabled on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Allow tf32 input for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add conversions for fp8 types on CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Add test_conversions.py to CI for CPU.

Signed-off-by: Ilya Enkovich <[email protected]>

* Fix formatting.

Signed-off-by: Ilya Enkovich <[email protected]>

---------

Signed-off-by: Ilya Enkovich <[email protected]>
Co-authored-by: Minjang Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants