[BACKEND] Extend hoisting of convert op above ext ops #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle more cases of hoisting convert above ext op. If there are multiple ext op in the slice but only one requires inserting a convert we can still apply the optimization.
Jokeren
reviewed
Aug 29, 2023
| // If we can rematerialize the rest of the ext slice we can ignore this | ||
| // ext as it won't need a convert. | ||
| if (result.succeeded()) { | ||
| slice.insert(tempSlice.begin(), tempSlice.end()); |
There was a problem hiding this comment.
Once the number of slice is changed, do you need to increase sliceSize as well?
There was a problem hiding this comment.
no, we only want to go through the original slice since here we get a backward slice without stopping at ext anymore. This new slice will be rematerialized without the need for convert so we don't have to consider it in looking for an ext that requires a convert.
Jokeren
approved these changes
Aug 29, 2023
| // If we can rematerialize the rest of the ext slice we can ignore this | ||
| // ext as it won't need a convert. | ||
| if (result.succeeded()) { | ||
| slice.insert(tempSlice.begin(), tempSlice.end()); |
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
Handle more cases of hoisting convert above ext op. If there are multiple ext op in the slice but only one requires inserting a convert we can still apply the optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle more cases of hoisting convert above ext op. If there are multiple ext op in the slice but only one requires inserting a convert we can still apply the optimization.