Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Improve docs and minor fixes for testing.py and core.py #4104

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

lancerts
Copy link
Contributor

@lancerts lancerts commented Jun 9, 2024

Description

Update the docs and a test case to cover more dtypes.

Template

The core Triton is a small number of people, and we receive many PRs (thank
you!). To help us review your code more quickly, if you are a new
contributor (less than 3 PRs merged) we ask that you complete the following
tasks and include the filled-out checklist in your PR description.

Complete the following tasks before sending your PR, and replace [ ] with
[x] to indicate you have done them.

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have used an LLM to copyedit my PR description and and code comments.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because update a test case to cover more dtype.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added are "minimal" -- they contain only the
      instructions necessary to exercise the bug. (Usually running Python code
      and using the instructions it generates is not minimal.)

@lancerts lancerts marked this pull request as ready for review June 9, 2024 21:59
@lancerts lancerts requested a review from ptillet as a code owner June 9, 2024 21:59
@lancerts lancerts changed the title [DOCS] Improve docs and minor fixes [DOCS] Improve docs and minor fixes for testing and core Jun 9, 2024
@lancerts lancerts changed the title [DOCS] Improve docs and minor fixes for testing and core [DOCS] Improve docs and minor fixes for testing.py and core.py Jun 9, 2024
@ptillet ptillet merged commit 71b8d33 into triton-lang:main Jun 10, 2024
6 checks passed
@lancerts lancerts deleted the doc-improve branch June 10, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants