Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass repr=key when calling JITFunction.cache_hook #4207

Closed
wants to merge 1 commit into from
Closed

Commits on Jun 25, 2024

  1. Pass repr=key when calling JITFunction.cache_hook.

    Before this PR, we had two key-like strings for JITFunctions.
    
     - key: Guaranteed unique per compiled kernel, suitable for caching.
     - repr: Not guaranteed-unique, missing some fields (for example, can't
       distinguish between fp32 and fp16 params), but perhaps more human-readable
       than `key`?
    
    This PR removes repr and replaces it with key, thus removing a footgun.
    jlebar committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    fb9aef3 View commit details
    Browse the repository at this point in the history