[BACKEND] Emit an error when the tensor shape is smaller than the shared memory tile size for shared encoding with leadingOffset=True. #4731
Conversation
| if (shape[colDim] < tileCols || shape[rowDim] < tileRows) { | ||
| llvm::errs() << "Illegal shared layout; expected shape to be at least [" | ||
| << tileRows << ", " << tileCols << "], shape: [" | ||
| << shape[rowDim] << ", " << shape[colDim] << "]\n"; | ||
| llvm::report_fatal_error("Illegal shared layout"); | ||
| } |
There was a problem hiding this comment.
sorry missed this review. One question: could this be part of the verifier?
There was a problem hiding this comment.
You mean add a verifier for SharedEncodingAttr? Maybe we can just emit an error in SharedEncodingAttr's builder
There was a problem hiding this comment.
it would be more memdesc type verifier (I believe we have some of those already).
Maybe we can just emit an error in SharedEncodingAttr's builder
it depends on the memdesc shape which wouldn't be known in the builder right?
There was a problem hiding this comment.
I'm referring to this builder interface.
Does it look good to you?
There was a problem hiding this comment.
ah yeah I guess that works. It wouldn't catch other cases but that's the only place where we create those anyway
No description provided.