Warn about usage of non-breaking space (#107)

* Throws better error for NBSP tokens [#85] Co-Authored-By: byara <[email protected]>
trivago · Apr 23, 2019 · 92bf980 · 92bf980
1 parent cf480e0
commit 92bf980
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@
 
 - incorrect 'is' method call in melody-types [#20](https://github.com/trivago/melody/issues/20)
 - getFocusedPath can break on IE11 for svg elements [#57](https://github.com/trivago/melody/issues/57)
+- Warn about usage of non-breaking space [#85](https://github.com/trivago/melody/issues/85)
 
 
 ### Chore & Maintenance

diff --git a/packages/melody-compiler/__tests__/__fixtures__/error/nonbreakable_space.template b/packages/melody-compiler/__tests__/__fixtures__/error/nonbreakable_space.template
@@ -0,0 +1 @@
+{{ 'success_msg' | sort }}
diff --git a/packages/melody-compiler/__tests__/__snapshots__/CompilerSpec.js.snap b/packages/melody-compiler/__tests__/__snapshots__/CompilerSpec.js.snap
@@ -2277,6 +2277,13 @@ Example:
 This is the placeholder content that will be shown to your users while the async component is being loaded."
 `;
 
+exports[`Compiler should fail transforming nonbreakable space.template 1`] = `
+"ERROR: Unsupported token: Non-breaking space
+> 1 | {{ 'success_msg' | sort }}
+    |                   ^
+  2 | "
+`;
+
 exports[`Compiler should fail transforming unknown filter.template 1`] = `
 "Unknown filter \\"unknown\\"
 > 1 | {{ test | unknown }}

diff --git a/packages/melody-parser/src/Lexer.js b/packages/melody-parser/src/Lexer.js
@@ -355,6 +355,11 @@ export default class Lexer {
                 } else if (CHAR_TO_TOKEN.hasOwnProperty(c)) {
                     input.next();
                     return this.createToken(CHAR_TO_TOKEN[c], pos);
+                } else if (c === '\xa0') {
+                    return this.error(
+                        'Unsupported token: Non-breaking space',
+                        pos
+                    );
                 } else {
                     return this.error(`Unknown token ${c}`, pos);
                 }