Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Sc/polytropic 2d wave speed #1816

Merged
merged 168 commits into from
Feb 20, 2024
Merged

WIP: Sc/polytropic 2d wave speed #1816

merged 168 commits into from
Feb 20, 2024

Conversation

SimonCan
Copy link
Contributor

Added wave speeds to the PolytropicEulerEquations2D equations.

SimonCan and others added 30 commits June 26, 2023 16:31
@SimonCan
Added coupling converters.
bb07419
@SimonCan
Added generic converter_function for structured 2d meshes.
95892bf
@SimonCan
Added example elixir for coupling converters.
4e82276
@SimonCan
Cleaned up converter coupling elixir.
7355ed0
@SimonCan
Added equations in coupling converters.
b8cabf4
@SimonCan
Added converter functions.
6d521a7
@SimonCan
Added identity converter function.
ab8e750
@SimonCan
Autoformat for converter coupling implementation.
24773c7
@SimonCan
Added coupled converter elixir.
c7da2cc
@SimonCan
Corrected file name of coupled converters test.
98bf2cf
@sloede
Merge branch 'main' into sc/converters_coupling
79da4e9
@SimonCan
Removed redundant doc string.
d97302d
@SimonCan
Added function signature in doc string.
4a22bfe
@SimonCan
Removed coverage_override in coupled tests.
f1f6ee8
@SimonCan
Removed old commented code.
7a7def0
@SimonCan
Update make.jl
9045c5d 
Added interface coupling docs to the main menu.
@SimonCan
Update make.jl
31cf07f 
Moved converter coupling section.
@SimonCan
Create coupling.md
2f19315
@SimonCan
Update coupling.md
26d8dd3 
Added some documentation on coupling converters.
@SimonCan
Removed troublesome AnalysisCallbackCoupled from test.
05579d1
@SimonCan
Chenged coupling converter function.
84c872e
@SimonCan
Changed coupling converter function and updated tests.
78f9948
@SimonCan
Sepcialized coupling function call.
2e35046
@SimonCan
Removed volume coupling from documentation to avoit confusion.
6bc7c3b
@SimonCan @ranocha
Update src/coupling_converters/coupling_converters.jl
b4decb7 
Co-authored-by: Hendrik Ranocha <[email protected]>
@SimonCan
Removed redundant converter function for coupling.
54d8180
@SimonCan
Removed redundant coupling converter file mentioned in some files.
160c7bf
@SimonCan
Merge branch 'sc/converters_coupling' of github.com:trixi-framework/T…
8a2187a 
…rixi.jl into sc/converters_coupling
@SimonCan
Autoreformatted.
cab33c2
@SimonCan
Removed old coupled elixir and replaced it with one using converter f…
024106c 
…unctions.
@ranocha
Copy link
Member

ranocha commented Jan 31, 2024

Please start from a clean state for future PRs. This one includes a huge amount of unrelated history.

@SimonCan
Copy link
Contributor Author

Restarting this PR from a clean state.

@SimonCan SimonCan closed this Jan 31, 2024
@ranocha
Copy link
Member

ranocha commented Jan 31, 2024

Sorry, that's not necessary for this one. I would just like to ask you to start with a clean state in the future. We can go ahead with this one as it is - whatever you prefer

@SimonCan SimonCan reopened this Feb 1, 2024
@SimonCan
Copy link
Contributor Author

SimonCan commented Feb 5, 2024

We should perform the usual tests for this (consistency & rotation)

Just add the usual rotation and consistency tests. They pass locally.

DanielDoehring
DanielDoehring previously approved these changes Feb 6, 2024
View reviewed changes
@SimonCan
Copy link
Contributor Author

SimonCan commented Feb 6, 2024

I believe I found a bug in the new wavespeed implementations. I also left a few comments just to clarify how the coupling conversion is done.

The bug should be fixed now.

@SimonCan SimonCan marked this pull request as ready for review February 7, 2024 15:11
@DanielDoehring
Copy link
Contributor

Anything that prevents this from being merged @andrewwinters5000 @SimonCan ?

andrewwinters5000
andrewwinters5000 requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me once my (minor) comment is addressed.

src/equations/polytropic_euler_2d.jl Outdated Show resolved Hide resolved
andrewwinters5000
andrewwinters5000 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can merge this.

@andrewwinters5000 andrewwinters5000 enabled auto-merge (squash) February 16, 2024 05:03
@andrewwinters5000 andrewwinters5000 merged commit c5e743a into main Feb 20, 2024
33 of 36 checks passed
@andrewwinters5000 andrewwinters5000 deleted the sc/polytropic_2d_wave_speed branch February 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede left review comments

@JoshuaLampert JoshuaLampert JoshuaLampert left review comments

@andrewwinters5000 andrewwinters5000 andrewwinters5000 approved these changes

@DanielDoehring DanielDoehring DanielDoehring approved these changes

@amrueda amrueda amrueda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SimonCan @ranocha @DanielDoehring @sloede @andrewwinters5000 @amrueda @JoshuaLampert @iomsn