Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and macOS CI tests and only run coverage on Ubuntu with latest Julia version #444

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Mar 6, 2024

This produces the following runs:

  1. Ubuntu latest, Julia latest. This is our "main run" and it's running unit tests with coverage and uploading to Codecov.
  2. Ubuntu latest, Julia 1.9.
  3. Windows latest, Julia latest.
  4. macOS-ARM, Julia latest.

Closes #435.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.84%. Comparing base (3189426) to head (7616c74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   70.84%   70.84%           
=======================================
  Files          66       66           
  Lines        3807     3807           
=======================================
  Hits         2697     2697           
  Misses       1110     1110           
Flag Coverage Δ
unit 70.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber changed the title Run coverage tests only with latest Julia version Run coverage tests only with latest Julia version and add Windows and macOS CI tests Mar 6, 2024
@efaulhaber efaulhaber changed the title Run coverage tests only with latest Julia version and add Windows and macOS CI tests Add Windows and macOS CI tests and only run coverage on Ubuntu with latest Julia version Mar 6, 2024
@efaulhaber efaulhaber mentioned this pull request Mar 6, 2024
@sloede
Copy link
Member

sloede commented Mar 6, 2024

FWIW, I'd additionally run

  • macOS (x64), Julia latest
  • Ubuntu latest, Julia v1.8

though with a reduced test set. If you are only able to run the full testset, then it's probably too much though

@efaulhaber
Copy link
Member Author

We don't have a reduced test set (yet).

@efaulhaber efaulhaber marked this pull request as ready for review March 6, 2024 09:56
@svchb
Copy link
Collaborator

svchb commented Mar 6, 2024

1.8 doesn't really work since there is this timestepping bug in OrdinaryDiffEq.jl that was fixed in a version, which has julia compat 1.9.

@svchb svchb enabled auto-merge (squash) March 6, 2024 21:59
@efaulhaber efaulhaber disabled auto-merge March 8, 2024 07:02
@efaulhaber efaulhaber merged commit a3ffe9d into trixi-framework:main Mar 8, 2024
8 checks passed
@efaulhaber efaulhaber deleted the coverage-latest-only branch March 8, 2024 07:02
@efaulhaber
Copy link
Member Author

1.8 doesn't really work since there is this timestepping bug in OrdinaryDiffEq.jl that was fixed in a version, which has julia compat 1.9.

You're right. It doesn't make sense to support Julia 1.8. This bug made a lot of simulations abort with "instability detected" when using saving and postprocess callback.
IIRC, this was SciML/OrdinaryDiffEq.jl#1616, fixed by SciML/OrdinaryDiffEq.jl#2098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants