-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows and macOS CI tests and only run coverage on Ubuntu with latest Julia version #444
Add Windows and macOS CI tests and only run coverage on Ubuntu with latest Julia version #444
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 70.84% 70.84%
=======================================
Files 66 66
Lines 3807 3807
=======================================
Hits 2697 2697
Misses 1110 1110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FWIW, I'd additionally run
though with a reduced test set. If you are only able to run the full testset, then it's probably too much though |
We don't have a reduced test set (yet). |
1.8 doesn't really work since there is this timestepping bug in OrdinaryDiffEq.jl that was fixed in a version, which has julia compat 1.9. |
You're right. It doesn't make sense to support Julia 1.8. This bug made a lot of simulations abort with "instability detected" when using saving and postprocess callback. |
This produces the following runs:
Closes #435.