refactor: Rewrite in TypeScript.

[avocadowastaken]

No description provided.

[avocadowastaken]

Published with #21 to https://npmjs.com/@dc0de/react-apollo-hooks

[trojanowski]

Thanks @umidbekkarimov for your great work here. I'll do a full review after Christmas, but right now I have 2 suggestions:

1. I'd like to have the git history and changelog (generated by standard-version) easy to follow so I'd like to merge it using the "Squash and merge" option. It would be great if this PR just renames the current files and adds TS types there (so index.js -> index.ts etc.), and splitting hooks to separate files is done in a follow-up PR.
2. I'd use TSLint instead of ESLint for linting the TypeScript code. It seems more popular for that case and it's also already used in Apollo repositories. I'm using this configuration in my projects (maybe it needs some customization):

{
  "defaultSeverity": "error",
  "extends": ["tslint:latest", "tslint-react", "tslint-config-prettier"],
  "jsRules": {},
  "rules": {
    "interface-name": false,
    "interface-over-type-literal": false,
    "jsx-boolean-value": [true, "never"],
    "jsx-no-lambda": false,
    "max-classes-per-file": false,
    "member-access": false,
    "no-implicit-dependencies": true,
    "no-submodule-imports": false,
    "no-this-assignment": [true, { "allow-destructuring": true }],
    "no-unused-expression": [true, "allow-fast-null-checks"],
    "only-arrow-functions": false,
    "ordered-imports": [
      true,
      {
        "import-sources-order": "lowercase-last",
        "named-imports-order": "lowercase-last"
      }
    ],
    "prefer-template": true
  },
  "rulesDirectory": []
}

Please let me know if you don't have time for that - I'd do it myself in the next week in that case.

[avocadowastaken]

I'd like to have the git history and changelog (generated by standard-version) easy to follow so I'd like to merge it using the "Squash and merge" option. It would be great if this PR just renames the current files and adds TS types there (so index.js -> index.ts etc.), and splitting hooks to separate files is done in a follow-up PR.

Done, I tried save git history as much as possible in force pushed commits but git still wants to "remove and add" index.tsx and objToKey.ts files.

I'd use TSLint instead of ESLint for linting the TypeScript code. It seems more popular for that case and it's also already used in Apollo repositories. I'm using this configuration in my projects (maybe it needs some customization):

Done.

I'll do a full review after Christmas

Happy Holidays!

[trojanowski]

I'd like to have the git history and changelog (generated by standard-version) easy to follow so I'd like to merge it using the "Squash and merge" option. It would be great if this PR just renames the current files and adds TS types there (so index.js -> index.ts etc.), and splitting hooks to separate files is done in a follow-up PR.

Done, I tried save git history as much as possible in force pushed commits but git still wants to "remove and add" index.tsx and objToKey.ts files.

Thank you. Anyway, it was easier to compare.

I added some comments. I'm going to split index.ts to separate files after merging this PR (similar how is it done in #42 - I'm going to review that one tomorrow).

[trojanowski]

I always try to group builtin node modules (not used here), external dependencies and internal ones together, separated by a blank line. I haven't found a tslint rule or config for that but I think is a good practice. I'd also change that in queryCache.ts.

[avocadowastaken]

Maybe this is the solution https://github.com/renke/import-sort? I has similar api as prettier: --write and --list-different.

[avocadowastaken]

@trojanowski Thanks, It's good to have you back! I've resolved your comments.

I hate to bring it up, code style changes (e.g. sorting of imports) should be done by tools, not humans. Prettier spoiled me.

[trojanowski]

Thank you @umidbekkarimov

I added one comment about the new changes.

I hate to bring it up, code style changes (e.g. sorting of imports) should be done by tools, not humans. Prettier spoiled me.

I agree. Thanks for the tip about import-sort - I'll try to add it.

[avocadowastaken]

I added one comment about the new changes.

@trojanowski I can't find any, maybe you forgot to submit it?

[trojanowski]

@trojanowski I can't find any, maybe you forgot to submit it?

Yes, sorry. It should be already visible.

[avocadowastaken]

@trojanowski Good catch, done. Also 3 another PRs are on the way 🙂

[trojanowski]

I added one last-minute comment. I think it's the last one :)

[avocadowastaken]

No problem, it's never easy to review 20+ file PRs. Fixed.

[avocadowastaken]

Forgot to push 🤦‍♂️