Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update all docs #18

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Docs: Update all docs #18

merged 1 commit into from
Oct 12, 2023

Conversation

raychen911
Copy link
Contributor

Update all docs

@@ -18,20 +18,20 @@
* [开发http上传/下载服务](./zh/http_protocol_upload_download_service.md)
* [开发grpc协议服务](./zh/grpc_protocol_service.md)
* [开发grpc流式服务](./zh/grpc_protocol_streaming_service.md)
* [开发flatbuffers协议服务](docs/en/xxx.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xxx.md改成真实的

* 客户端开发
* [开发向导](./zh/client_guide.md)
* [访问trpc协议服务](./zh/client_guide.md)
* [访问trpc流式协议服务](./zh/trpc_protocol_streaming_client.md)
* [访问http(s)协议服务](./zh/http_protocol_client.md)
* [访问http上传/下载服务](./zh/http_protocol_upload_download_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_streaming_client.md.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了.md

@@ -40,6 +40,6 @@ class ServerContext {

/// @brief Set response attachment data
void SetResponseAttachment(NoncontiguousBuffer&& attachment);
...
// ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加空格?

* 客户端开发
* [开发向导](./zh/client_guide.md)
* [访问trpc协议服务](./zh/client_guide.md)
* [访问trpc流式协议服务](./zh/trpc_protocol_streaming_client.md)
* [访问http(s)协议服务](./zh/http_protocol_client.md)
* [访问http上传/下载服务](./zh/http_protocol_upload_download_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_streaming_client.md.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpc_protocol_client.md is needed here.

* 客户端开发
* [开发向导](./zh/client_guide.md)
* [访问trpc协议服务](./zh/client_guide.md)
* [访问trpc流式协议服务](./zh/trpc_protocol_streaming_client.md)
* [访问http(s)协议服务](./zh/http_protocol_client.md)
* [访问http上传/下载服务](./zh/http_protocol_upload_download_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_client.md)
* [访问grpc协议服务](./zh/grpc_protocol_streaming_client.md.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpc client streaming is not available now, so it's ok to remove it.
Suffix name ".md " in grpc_protocol_streaming_client.md.md is redundant.

@helloopenworld helloopenworld merged commit 03c5f59 into trpc-group:main Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants