-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131407 / 25.04 / Experiment with alternatives to slide-ins #10826
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other challenges that need to be solved:
- Placement of Save button.
- Content left side should be aligned with header.
- There can be more padding, because we now have more space for the form to breeze.
- Feels like background dimming should be stronger (at least it is stronger with slide-ins).
- Logging out (for example via timeout) should close open sheets.
- Scrolling. Right now scrollbar is show next to header, but header is sticky. We could try with full page scrolling, where there is a scrollbar on global container and when sheet is scrolled, header sticks to the top of the page. If it's too complicated, we could have scrolling in sheet body only.
Let's focus on one of the forms (user form) for now.
You can make alterations via demo CSS.
src/app/modules/forms/ix-forms/components/form-actions/form-actions.component.html
Outdated
Show resolved
Hide resolved
...orms/ix-forms/components/ix-slide-in/components/ix-modal-header/ix-modal-header.component.ts
Outdated
Show resolved
Hide resolved
2098f7c
to
3fbd4f6
Compare
@dszidi The idea behind this ticket is that it's probably not ideal that users have to do a lot of things in sidebar forms. There is a lot of screen space available, but we force users to use 20% of it. Here are some of the rough options we came up with: Any advice for us? |
For demo purposes.