Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131407 / 25.04 / Experiment with alternatives to slide-ins #10826

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

@denysbutenko denysbutenko commented Oct 9, 2024

For demo purposes.

@bugclerk bugclerk changed the title NAS-131407: Experiment with alternatives to slide-ins NAS-131407 / 25.04 / Experiment with alternatives to slide-ins Oct 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Oct 9, 2024

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some other challenges that need to be solved:

  • Placement of Save button.
  • Content left side should be aligned with header.
  • There can be more padding, because we now have more space for the form to breeze.
  • Feels like background dimming should be stronger (at least it is stronger with slide-ins).
  • Logging out (for example via timeout) should close open sheets.
  • Scrolling. Right now scrollbar is show next to header, but header is sticky. We could try with full page scrolling, where there is a scrollbar on global container and when sheet is scrolled, header sticks to the top of the page. If it's too complicated, we could have scrolling in sheet body only.

Let's focus on one of the forms (user form) for now.
You can make alterations via demo CSS.

@denysbutenko denysbutenko marked this pull request as ready for review October 17, 2024 09:00
@denysbutenko denysbutenko requested a review from a team as a code owner October 17, 2024 09:00
@denysbutenko denysbutenko requested review from AlexKarpov98 and undsoft and removed request for a team October 17, 2024 09:00
@undsoft
Copy link
Collaborator

undsoft commented Oct 18, 2024

@dszidi The idea behind this ticket is that it's probably not ideal that users have to do a lot of things in sidebar forms. There is a lot of screen space available, but we force users to use 20% of it.

Here are some of the rough options we came up with:
Снимок экрана 2024-10-18 в 10 32 45

Снимок экрана 2024-10-15 в 11 08 18 Снимок экрана 2024-10-15 в 10 54 49

Any advice for us?

@AlexKarpov98 AlexKarpov98 removed their request for review October 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants