NAS-131213 / 25.04 / Refactor out auth.two_factor_auth
#10873
+115
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10873 +/- ##
==========================================
+ Coverage 81.92% 81.97% +0.05%
==========================================
Files 1594 1604 +10
Lines 55589 61191 +5602
Branches 5816 7246 +1430
==========================================
+ Hits 45540 50161 +4621
- Misses 10049 11030 +981 ☔ View full report in Codecov by Sentry. |
|
@RehanY147 it turned out that I need to work more on this one. please reject, so I could request a re-review once I'm done |
anodos325
reviewed
Oct 16, 2024
bvasilenko
force-pushed
the
NAS-131213
branch
from
e0991ae
to
ec56e1d
Compare
bvasilenko
changed the title
auth.two_factor_auth
RehanY147
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Follow these steps
- Setup 2FA for user
- Go to login page
- Enter username/password and click the login button. The 2FA input will show up
- Click Cancel to go back to the original login page
- Enter username and password again and click 'Login'
You will see the following error shown in the screenshot
Expect:
User can login with new credentials
Actual:
User is shown an error about login in progress?
| ); | ||
| }), | ||
| const payload: LoginExQuery = otp | ||
| ? { mechanism: 'OTP_TOKEN', otp_token: otp } |
There was a problem hiding this comment.
mechanism value should be an enum
|
Discussed the issue Rehan discovered with Andrew. Middleware will make some adjustments and we'd have to revisit this once those changes are done. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Refactoring for login page
Testing:
Test logging in using both regular credentials and 2FA , and number of calls should be less than it was before.