Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128566 / 25.04 / Always display the Lock button on the encryption card #10900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bvasilenko
Copy link
Contributor

Changes:

The purpose of the task is to add a disabled Lock button with a message for datasets created with a key, so that the user does not have questions about what is happening.

Testing:

Go to Datasets > (Choose a dataset) and try to click Lock button

Expected result: warning "This dataset cannot be locked"

@bvasilenko bvasilenko requested a review from a team as a code owner October 21, 2024 06:22
@bvasilenko bvasilenko requested review from undsoft and removed request for a team October 21, 2024 06:22
@bugclerk bugclerk changed the title NAS-128566: Always display the Lock button on the encryption card NAS-128566 / 25.04 / Always display the Lock button on the encryption card Oct 21, 2024
@bugclerk
Copy link
Contributor

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disabled button is there.

<button
mat-button
ixTest="lock"
[matTooltip]="!hasPassphrase ? ('This dataset cannot be locked' | translate) : ''"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add full tooltip as described in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants