Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131802 / 24.10.1 / Error with some dataset paths in pool creation (by undsoft) #10907

Open
wants to merge 2 commits into
base: stable/electriceel
Choose a base branch
from

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x e5ec05e5c506cdd6a42c7bb11c83c6314bce8b6b

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 93d1b7fe707a3267ee959fbe35d472ea2c3eff01

Testing:

The easier way to reproduce the original issue is to:

  1. Go to Shares -> SMB -> Add
  2. Select a dataset.
  3. Add trailing slash in the input.
  4. Click Create Dataset.

Original PR: #10897
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131802

@undsoft undsoft marked this pull request as ready for review October 21, 2024 14:46
@undsoft undsoft requested a review from a team as a code owner October 21, 2024 14:46
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team October 21, 2024 14:46
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@284e505). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...-dataset-dialog/create-dataset-dialog.component.ts 54.54% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10907   +/-   ##
=====================================================
  Coverage                      ?   79.94%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51403           
  Branches                      ?     5939           
=====================================================
  Hits                          ?    41094           
  Misses                        ?    10309           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants