Fixed github oauth2 token detector #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Oct 1, 2024
| @@ -70,7 +70,10 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| } | |||
| if verify { | |||
| _, err := config.Token(ctx) | |||
| // if client id and client secret is correct, it will return bad verification code error as we do not pass any verification code | |||
| // docs: https://docs.github.com/en/apps/oauth-apps/maintaining-oauth-apps/troubleshooting-oauth-app-access-token-request-errors#bad-verification-code | |||
kashifkhan0771
added a commit
to kashifkhan0771/trufflehog
that referenced
this pull request
Oct 1, 2024
kashifkhan0771
added
hacktoberfest-2024
hacktoberfest-2024-internal
and removed
hacktoberfest-2024
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed the regex for github oauth client id
Added comments for verification handling
Checklist:
make test-community)?make lintthis requires golangci-lint)?