Add SliceContainsString common util

[bill-rich]

No description provided.

[sysread]

Personally, I would include the matched index in the return value, but that's a nitpick for sure.

[ahrav]

suggestion: If ignoreCase is true, we can avoid the overhead of calling strings.ToLower on each slice item by performing the conversion once for origTargetString.

Ex:

if ignoreCase {
		targetString := strings.ToLower(origTargetString)
		for _, stringFromSlice := range stringSlice {
			if targetString == strings.ToLower(stringFromSlice) {
				return true, origTargetString
			}
		}
	} else {
		for _, stringFromSlice := range stringSlice {
			if origTargetString == stringFromSlice {
				return true, origTargetString
			}
		}
	}
	return false, ""

[bill-rich]

It currently only does the ToLower conversion if ignoreCase is true. The original way does the check on every iteration, uses the same loop.

[ahrav]

Oh right duh!

[ahrav]

question: How large are you anticipating stringSlice being?

[bill-rich]

I imagine most cases won't be huge, but didn't really have a limit in mind.

[bill-rich]

Personally, I would include the matched index in the return value, but that's a nitpick for sure.

Good call. Added

[ahrav]

question: How come you created targetString and stringFromSlice vars as opposed to updating the existing values? Was it solely for clarity?

if ignoreCase {
    origTargetString = strings.ToLower(origTargetString)
}

similarly for:

if ignoreCase {
    origStringFromSlice = strings.ToLower(origStringFromSlice)
}