Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order log context fields #3430

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 16, 2024

Description:

This bugs me.

2024-10-15T22:41:33-04:00 info-0 trufflehog scanning repo
{
"source_manager_worker_id": "9STWR", "unit": "https://github.com/Azure/Azure-MachineLearning-ClientLibrary-R.git", "unit_kind": "repo", "repo": "https://github.com/Azure/Azure-MachineLearning-ClientLibrary-R.git"
}

More seriously, the log context ideally wouldn't be duplicating the repo URL for every log message... I don't know what the best way to handle this is.

2024-10-15T22:39:57-04:00 info-0 trufflehog scanning repo {"source_manager_worker_id": "9STWR", "unit": "https://github.com/Azure/go-ansiterm.git", "unit_kind": "repo", "repo": "https://github.com/Azure/go-ansiterm.git"}
2024-10-15T22:41:45-04:00 info-0 trufflehog scanning repo {"source_manager_worker_id": "9STWR", "unit": "https://github.com/Azure/azure-storage-python.git", "unit_kind": "repo", "repo": "https://github.com/Azure/azure-storage-python.git"}

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner October 16, 2024 14:25
@rosecodym
Copy link
Collaborator

I think you might be the only person who cares about this - but as the only person who cares about this, you get to decide!

@rosecodym rosecodym merged commit 06e37ca into trufflesecurity:main Oct 23, 2024
13 checks passed
@rgmz rgmz deleted the chore/log-field-order branch October 23, 2024 14:53
@rgmz
Copy link
Contributor Author

rgmz commented Oct 23, 2024

but as the only person who cares about this, you get to decide!

I'll try not to let the power go to my head. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants