Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] - Context timeout #3460

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[fix] - Context timeout #3460

merged 1 commit into from
Oct 17, 2024

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented Oct 17, 2024

Description:

This PR isolates the context used for object retrieval, ensuring the timeout is applied only to the GetObjectWithContext call. Previously, the context was propagated to HandleFile, causing operations to fail if a file wasn't processed within 5 seconds.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@ahrav ahrav marked this pull request as ready for review October 17, 2024 19:46
@ahrav ahrav requested a review from a team as a code owner October 17, 2024 19:46
rosecodym
rosecodym approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@ahrav ahrav merged commit 871a2b0 into main Oct 17, 2024
13 checks passed
@ahrav ahrav deleted the bug-fix-timeout branch October 17, 2024 19:53
@blsaccess blsaccess mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosecodym rosecodym rosecodym approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @rosecodym