feat: added v3 API version for the detector captaindatago
#3484
Conversation
|
Verified with API Key @rgmz |
| } | ||
|
|
||
| // Ensure the Scanner satisfies the interface at compile time. | ||
| var _ detectors.Detector = (*Scanner)(nil) |
There was a problem hiding this comment.
The versioning interface is currently unimplemented. When running trufflehog, the following warning is displayed:
2024-10-25T11:39:18+05:00 info-0 trufflehog possible duplicate detector configured {"detector": "CaptainData"}
There was a problem hiding this comment.
How are you testing this @kashifkhan0771 , can you tell me the command?
There was a problem hiding this comment.
Add your token in some file locally and run following command against it
trufflehog filesystem ~/<path_to_file_where_secret_is>
There was a problem hiding this comment.
Thanks, I checked with the changes, this warning is not coming now, I have fixed it.
sahil9001
force-pushed
the
captaindata-v3-detector
branch
from
a1760ca
to
4a9bb67
Compare
Signed-off-by: Sahil Silare <[email protected]>
| @@ -1642,6 +1642,8 @@ func DefaultDetectors() []detectors.Detector { | |||
| saladcloudapikey.Scanner{}, | |||
| boxoauth.Scanner{}, | |||
| apimetrics.Scanner{}, | |||
| captainDataV2.Scanner{}, | |||
There was a problem hiding this comment.
If there is no V1 , We should start with V1
There was a problem hiding this comment.
Where is
V1?
I named them according to API versions available, there was v2 and v3 hence the name.
There was a problem hiding this comment.
I believe the versioning is based on detectors not the API. Correct me If I am wrong @zricethezav @abmussani
Correct way would be to start with V1
There was a problem hiding this comment.
Done, please check @kashifkhan0771
Signed-off-by: Sahil Silare <[email protected]>
Description:
Fixes #3483
Checklist:
make test-community)?make lintthis requires golangci-lint)?