Stop logging detailed group info #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
approved these changes
Oct 30, 2024
abmussani
approved these changes
Oct 30, 2024
camgunz
approved these changes
Oct 30, 2024
2 tasks
rosecodym
added a commit
that referenced
this pull request
Nov 1, 2024
#3532 stopped logging one huge GItLab slice, but there's a second one! We should stop logging it for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It is possible for large GitLab instances to have thousands of groups, in which case logging a structured object for each one just Will Not Work. While it would theoretically be possible to log only if there's a number of groups under some arbitrary cutoff, I think that just removing the log line categorically is simpler and easier to understand.
Checklist:
make test-community)?make lintthis requires golangci-lint)?