fix: Fork block number doesn't get populated (#5220)

* Fork block number doesn\'t get propogated back from the chain instance

* Change the label for fork block number field

src/integrations/ethereum/renderer/screens/config/ConfigScreens/ServerScreen.js

@@ -454,7 +454,7 @@ class ServerScreen extends Component {
                   />
                 </div> 
                 <div className="RowItem">
-                  <p>The URL of the block number to fork from, e.g., 56789</p>
+                  <p>The block number to fork from, e.g., 56789</p>
                 </div>
               </div> 
             </section>

src/integrations/index.js

@@ -97,8 +97,7 @@ class IntegrationManager extends EventEmitter {
       try {
         await this.flavor.startServer(settings, this.workspace.workspaceDirectory);
         // just incase startServer mutates the settings, save them
-        // todo: not sure whether we still need to do this?
-        this.workspace.settings.setAll(settings);
+        this.workspace.settings.setAll(this.workspace.settings.getAll());
 
         this.emit("server-started");
         return true;

static/node/chain/chain.ethereum.js

@@ -152,13 +152,15 @@ async function startServer(options) {
   dbLocation = ganacheOptions.database.dbPath;
 
   const { mnemonic, hdPath } = ganacheOptions.wallet;
+  const fork_block_number = ganacheOptions.fork?.blockNumber;
 
   // todo: what else do we need from options
   const data = {
     privateKeys,
     addresses,
     hdPath,
     mnemonic,
+    fork_block_number,
     dbLocation,
   };