Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

require() Truffle Project Configs in a Separate Process which Has No Native Dependencies #1086

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

mikeseese
Copy link
Contributor

@mikeseese mikeseese commented Jan 17, 2019

This PR fixes #1076 by using a separate process which uses the spawn("node") function instead of fork() for running the require() on a Truffle project. This will use the system-installed version of node rather than the packaged version that comes with electron.

@honestbonsai
Copy link
Contributor

honestbonsai commented Jan 18, 2019

LGTM

EDIT: actually, you can feel free to leave the console.log in, the linter is going to be set to just warn about those errors

@mikeseese
Copy link
Contributor Author

The console.log's I removed because of the linter are redundant anyway. The logs do bubble to a more appropriate place via throwing or event emitting.

@mikeseese mikeseese merged commit 6887c9c into develop Jan 18, 2019
@mikeseese mikeseese deleted the node-independent-truffle-int branch January 18, 2019 16:38
@adrianmcli adrianmcli mentioned this pull request Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Error when running Ganache 2.0.0-beta.2 on linux
2 participants