Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Hardfork #1107

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Hardfork #1107

merged 3 commits into from
Jan 30, 2019

Conversation

davidmurdoch
Copy link
Member

This PR (to master) updates Ganache v1 to [email protected], adds a new HARDFORK setting, and sets the default hardfork option to constantinople.

Screenshots

Adds HARDFORK to status menu:

image

Adds HARDFORK select list to SETTINGS menu:

image


This PR is intended to be followed by a minor version release: Ganache v1.3.0.

@adrianmcli
Copy link
Contributor

The code looks good to me, will take a look to see if it loads properly.

Copy link
Contributor

@honestbonsai honestbonsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

Tested on both forks. Ran some contract creation tx and seems to work.

Only comment from me is the style of the dropdown is quite different from the current Ganache ui style. Could always address in a separate issue + PR.

@adrianmcli
Copy link
Contributor

@davidmurdoch
Copy link
Member Author

For reference, this is example usage of the StyledSelect component:

ganache/src/renderer/screens/config/ConfigScreens/ServerScreen.js

Line 4 in aeaac84

import StyledSelect from "../../../components/styled-select/StyledSelect";

Fixed!

image

@davidmurdoch davidmurdoch removed the request for review from OnlyOneJMJQ January 30, 2019 23:02
@davidmurdoch davidmurdoch merged commit f30cf26 into master Jan 30, 2019
@adrianmcli
Copy link
Contributor

looks great, thanks @davidmurdoch!

@davidmurdoch davidmurdoch deleted the hardfork branch March 21, 2019 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants