s can be undefined here

trufflesuite · Mar 15, 2022 · 5f78b56 · 5f78b56
1 parent 9f0e3af
commit 5f78b56
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/chains/ethereum/transaction/src/transaction-factory.ts b/src/chains/ethereum/transaction/src/transaction-factory.ts
@@ -30,7 +30,7 @@ import { SECP256K1_MAX_PRIVATE_KEY_DIV_2 } from "@ganache/secp256k1";
 function assertValidTransactionSValue(common: Common, tx: LegacyTransaction | EIP2930AccessListTransaction | EIP1559FeeMarketTransaction) {
   // Transaction signatures whose s-value is greater than secp256k1n/2 are
   // invalid after the homestead hardfork. See: https://eips.ethereum.org/EIPS/eip-2
-  if (common.gteHardfork('homestead') && tx.s.toBigInt() > SECP256K1_MAX_PRIVATE_KEY_DIV_2) {
+  if (tx.s && tx.s.toBigInt() > SECP256K1_MAX_PRIVATE_KEY_DIV_2 && common.gteHardfork('homestead')) {
     throw new Error("Invalid Signature: s-values greater than secp256k1n/2 are considered invalid")
   }
 }