Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

"should return the timeAdjustment value via evm_increaseTime when provided as a number" test is flaky #3271

Closed
davidmurdoch opened this issue Jun 22, 2022 · 0 comments · Fixed by #3389
Closed

"should return the timeAdjustment value via evm_increaseTime when provided as a number" test is flaky #3271

davidmurdoch opened this issue Jun 22, 2022 · 0 comments · Fixed by #3389
Assignees
@jeffsmale90
Labels
priority3 🔧

Comments

@davidmurdoch
Copy link
Member

davidmurdoch commented Jun 22, 2022 •
edited
Loading

Presumably due to the combination of Math.floor and using the system clock for our tests.
@davidmurdoch davidmurdoch changed the title should return the timeAdjustment value via evm_increaseTime when provided as a number test is flaky "should return the timeAdjustment value via evm_increaseTime when provided as a number" test is flaky Jun 24, 2022
@cds-amal cds-amal assigned cds-amal and unassigned cds-amal Jun 30, 2022
@jeffsmale90 jeffsmale90 mentioned this issue Jul 13, 2022
Closed
@davidmurdoch davidmurdoch moved this to Inbox in Ganache Jul 19, 2022
@davidmurdoch davidmurdoch moved this from Inbox to Backlog in Ganache Jul 19, 2022
@jeffsmale90 jeffsmale90 mentioned this issue Jul 20, 2022
Merged
jeffsmale90 added a commit that referenced this issue Jul 20, 2022
@jeffsmale90
set internal offset to 0 if no start time is provided. resolves discr…
92048a5 
…epency between start time and the value returned from reference clock causing non-zero offset. fix: #3271
@jeffsmale90 jeffsmale90 linked a pull request Jul 20, 2022 that will close this issue
fix: if a timestamp is passed to evm_mine, subsequent blocks reflect the change in time #3317
Closed
@jeffsmale90 jeffsmale90 moved this from Backlog to In Progress in Ganache Jul 20, 2022
@jeffsmale90 jeffsmale90 self-assigned this Jul 20, 2022
jeffsmale90 added a commit that referenced this issue Jul 20, 2022
@jeffsmale90
set internal offset to 0 if no start time is provided. resolves discr…
8d56eae 
…epency between start time and the value returned from reference clock causing non-zero offset. fix: #3271
Repository owner moved this from In Progress to Done in Ganache Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffsmale90 jeffsmale90

Labels
priority3 🔧
Projects
Ganache
Status: Done
Milestone
No milestone
3 participants
@davidmurdoch @cds-amal @jeffsmale90