Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

move reporting of tx hash on error to error field to prevent poorly-written clients which assume that the existence of the "result" field implies no errors from breaking. #558

Closed
davidmurdoch opened this issue Apr 8, 2020 · 1 comment
Closed

move reporting of tx hash on error to error field to prevent poorly-written clients which assume that the existence of the "result" field implies no errors from breaking. #558

davidmurdoch opened this issue Apr 8, 2020 · 1 comment
Milestone
7.0.0

Comments

@davidmurdoch
Copy link
Member

move reporting of tx hash on error to error field to prevent poorly-written clients which assume that the existence of the "result" field implies no errors from breaking.
@davidmurdoch davidmurdoch added this to the 3.0.0 milestone Apr 8, 2020
@davidmurdoch
Copy link
Member Author

relative to above: don't return both result and an err, ever. Maybe. Need to discuss further.

davidmurdoch added a commit that referenced this issue Sep 2, 2020
@davidmurdoch
breaking: a result is no longer present when an error is returned. fixes
f8cdb73 
 #558 (for ganache v3 release only).
@davidmurdoch davidmurdoch mentioned this issue Oct 31, 2020
Merged
@Woodpile37 Woodpile37 mentioned this issue Aug 18, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@davidmurdoch