Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Support london hardfork #939

Closed
KaiRo-at opened this issue Jul 9, 2021 · 3 comments · Fixed by #1135
Closed

Support london hardfork #939

KaiRo-at opened this issue Jul 9, 2021 · 3 comments · Fixed by #1135
Assignees
Milestone

Comments

@KaiRo-at
Copy link

KaiRo-at commented Jul 9, 2021

This is basically the same as #821 just for London, which is already deployed on Ropsten and Goerli and coming to Ethereum mainnet in early August.

Expected Behavior

ganache-cli --hardfork london should work and behave like other Ethereum nodes running on London hardfork.

Current Behavior

Error: Hardfork with name london not supported

Possible Solution

I guess the solution is obvious, the EIPs in https://github.com/ethereum/eth1.0-specs/blob/master/network-upgrades/mainnet-upgrades/london.md need to be implemented and followed when that hardfork setting is there. Most importantly, that means support of EIP-1559 transactions.

Context

As with #821, running ganache should be good in finding out gas requirements on real networks, which due to more changes in this hardfork compared to Berlin, is even more wrong for networks that are already on London.

That said, as a testing environment, it would be even more important to be able to run tests with EIP-1559 transaction semantics to get them right in various code that should run against a real network. Right now, that's now possible with using ganache.

Your Environment

  • Version used: Ganache CLI v6.12.2 (ganache-core: 2.13.2)
  • NodeJS Version: v10.24.0
  • Operating System and version (include distro if Linux): openSUSE Linux
@KaiRo-at
Copy link
Author

One thing to note is that London also includes EIP-3198, which adds a BASEFEE opcode, so support of this HF is also needed for EVM compatibility.

@davidmurdoch davidmurdoch transferred this issue from trufflesuite/ganache-cli-archive Aug 11, 2021
@davidmurdoch davidmurdoch added this to the 7.0.0 milestone Aug 11, 2021
@davidmurdoch davidmurdoch linked a pull request Sep 9, 2021 that will close this issue
@MatthiasLohr
Copy link

Should that already be available via Docker image trufflesuite/ganache:v7.0.0-beta.0? I can run a container using this image with --hardfork london, so I assue it to be supported there, but I'm getting the following message with web3py:

The method eth_maxPriorityFeePerGas does not exist/is not available

Any idea? Running the same code against geth with london support, it works.

@davidmurdoch
Copy link
Member

@MatthiasLohr, I've created an issue to add support for this method. I think we'll just need to return a hardcoded 0x0. Some further investigation is needed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants