-
Notifications
You must be signed in to change notification settings - Fork 0
feat: refactor deploy script to use more dependency injection #27
Conversation
Will need to update to address for #28 |
7bba08a
to
d10d50f
Compare
1ce2841
to
7bba08a
Compare
7bba08a
to
d55d83d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good improvement to deployment script.
We will obviously need to add further WETH addresses when we consider deploying to further chains (and possibly rename it to wrapped-native or something sufficiently generalisable)
I can't seem to get the command brownie run deploy --network mainnet-fork
(which uses ganache) to work.
I get the error "AttributeError: 'AttributeDict' object has no attribute 'baseFeePerGas'"
When I do the hardhat fork it works perfectly.
I don't think we necessarily need to support ganache as hardhat provides all the necessary features for testing in a forked environment. It might be worth explicitly documenting that it only works with hardhat
Happy to merge once you've decided what we do with ganache |
It fails on |
Looks like For the time being I'm going to merge it in since this isn't something we can fix or is a blocker. |
What I did
How I did it
chain
as an argdeployment
dict perchain-id
How to verify it
Run
brownie run deploy
Checklist
Outstanding work
Other notes