This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
commented
Oct 5, 2021
davidmurdoch
reviewed
Oct 5, 2021
davidmurdoch
reviewed
Oct 5, 2021
src/chains/ethereum/transaction/src/eip1559-fee-market-transaction.ts
Outdated
Show resolved
Hide resolved
… into fix/eip-1559-tx-gas
davidmurdoch
suggested changes
Oct 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work here! Just a few comments/suggestions!
src/chains/ethereum/ethereum/tests/api/eth/contracts/Example.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: David Murdoch <[email protected]>
… into fix/eip-1559-tx-gas
davidmurdoch
approved these changes
Oct 7, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
effectiveGasPrice
toGanacheRawExtraTx
so that it is stored in the db.gasPrice
to storeeffectiveGasPrice
when creating the forked tx.effectiveGasPrice
to setgasPrice
when getting a tx from the db.gasPrice
when fetching viaeth_getTransactionByHash
would sometimes be wrong.eth_getTransactionByHash
to check more values than justtransactionIndex
.gasPrice
values line up for the very specific fail case.gasPrice
bugRuntimeBlock
where a 0 value forbaseFeePerGas
would completely leave out thebaseFeePerGas
field from the block.TransactionFactory
where a tx that omits the type but hasmaxFeePerGas
/maxPriorityFeePerGas
specified would have those fields overwritten. (notype
=> assume type 0, nogasPrice
=> upgrade to type 2 => assume no type 2 fields were given. the last assumption is wrong)Closes #1213 & #1214