Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Issue 678: Testing solidity strings with getters/setters #218

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e9bc6a3
Fixes #678: Confirmed that Solidity public strings can be updated wit…
cryptoweb3 Nov 7, 2018
b91d55c
Reverted changes to request.js while testing out a eslint configuration
cryptoweb3 Nov 7, 2018
49ca041
Fixes #678: Confirmed that Solidity public strings can be updated wit…
cryptoweb3 Nov 7, 2018
0469cc1
Reverted changes to request.js while testing out a eslint configuration
cryptoweb3 Nov 7, 2018
496a7ff
Merge branch 'issue-678' of github.com:trufflesuite/ganache-core into…
cryptoweb3 Nov 7, 2018
56d3087
Added updated npm-shrinkwrap
cryptoweb3 Nov 7, 2018
d52dbf8
Resolves #678: Renamed test file to help avoid merge issues
cryptoweb3 Nov 7, 2018
1bfe4bc
Adding renamed test file
cryptoweb3 Nov 7, 2018
82be61b
Removed unneeded 'new' from Ganache provider instance
cryptoweb3 Nov 7, 2018
c104398
Cleaned up unnecessary code and add some es6 reactoring.
cryptoweb3 Nov 8, 2018
9335d3a
Destructured accounts and contract instance
cryptoweb3 Nov 8, 2018
4e80e6f
Add set confirmation to the contract
cryptoweb3 Nov 10, 2018
96746d9
Added support for basic multicontract compile and deployments
cryptoweb3 Nov 11, 2018
153e82b
Cleaned up a couple of function interfaces
cryptoweb3 Nov 12, 2018
62716c2
Updated shrinkwrap.
cryptoweb3 Nov 13, 2018
188abbd
Merge branch 'develop' into issue-678
cryptoweb3 Nov 13, 2018
47268a4
Fixes trufflesuite/ganache#678: Confirmed that Solidity public string…
cryptoweb3 Nov 7, 2018
c14838e
Merge branch 'issue-678' of github.com:trufflesuite/ganache-core into…
cryptoweb3 Nov 13, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 8 additions & 33 deletions lib/blockchain_double.js
Original file line number Diff line number Diff line change
Expand Up @@ -243,26 +243,14 @@ BlockchainDouble.prototype.putBlock = function(block, logs, receipts, callback)
var requests = [
self.database.blocks.push.bind(self.database.blocks, block),
self.database.blockLogs.push.bind(self.database.blockLogs, logs),
self.database.blockHashes.set.bind(
self.database.blockHashes,
to.hex(block.hash()),
length
)
self.database.blockHashes.set.bind(self.database.blockHashes, to.hex(block.hash()), length)
];

block.transactions.forEach(function(tx, index) {
var txHash = to.txHash(tx);
requests.push(
self.database.transactions.set.bind(
self.database.transactions,
txHash,
tx
),
self.database.transactionReceipts.set.bind(
self.database.transactionReceipts,
txHash,
receipts[index]
)
self.database.transactions.set.bind(self.database.transactions, txHash, tx),
self.database.transactionReceipts.set.bind(self.database.transactionReceipts, txHash, receipts[index])
);
});

Expand Down Expand Up @@ -305,28 +293,15 @@ BlockchainDouble.prototype.popBlock = function(callback) {
var txHash = to.txHash(tx);

requests.push(
self.database.transactions.del.bind(
self.database.transactions,
txHash
),
self.database.transactionReceipts.del.bind(
self.database.transactionReceipts,
txHash
)
self.database.transactions.del.bind(self.database.transactions, txHash),
self.database.transactionReceipts.del.bind(self.database.transactionReceipts, txHash)
);
});

requests.push(
self.database.blockLogs.pop.bind(
self.database.blockLogs
),
self.database.blockHashes.del.bind(
self.database.blockHashes,
blockHash
),
self.database.blocks.pop.bind(
self.database.blocks
) // Do this one last in case anything relies on it.
self.database.blockLogs.pop.bind(self.database.blockLogs),
self.database.blockHashes.del.bind(self.database.blockHashes, blockHash),
self.database.blocks.pop.bind(self.database.blocks) // Do this one last in case anything relies on it.
);

async.series(requests, function(err) {
Expand Down
Loading