This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: Close http connections after http-server.close() has been called #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
changed the title
…sponses shall have the underlying connection closed #2185 * This does not yet work in all cases, as uws-js-unofficial fallback does not support .close() * Simple test case added to ensure that after calling close and a single succcessful request, all subsequent requests will fail.
…a test to ensure no new connections are accepted while closing, and other persistent connections are still open
jeffsmale90
force-pushed
the
fix/close-http-connection
branch
from
8973873
to
2105247
Compare
Co-authored-by: David Murdoch <[email protected]>
…pcJson for server tests
MicaiahReid
reviewed
Mar 25, 2022
MicaiahReid
approved these changes
Mar 25, 2022
…se the connection
davidmurdoch
approved these changes
Apr 1, 2022
davidmurdoch
added a commit
that referenced
this pull request
Apr 4, 2022
…#2667) fixes #2185 Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Micaiah Reid <[email protected]>
MicaiahReid
added a commit
to domob1812/ganache
that referenced
this pull request
Apr 20, 2022
…trufflesuite#2667) fixes trufflesuite#2185 Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Micaiah Reid <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2185