Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

chore: add relevant keywords to ganache's package.json #3151

Merged
merged 1 commit into from
May 31, 2022

Conversation

davidmurdoch
Copy link
Member

@davidmurdoch davidmurdoch commented May 28, 2022

Users reported that it was difficult to find the ganache package in the npm registry because they were used to searching for ganache-cli and ganache-core. This change adds those terms to our package.json's "keywords" list, which hopefully alleviates the problem.

Fixes #3143

@jeffsmale90
Copy link
Contributor

Looks good to me. Is there anything else we need to do in order to push users over fromganache-cli?

@davidmurdoch
Copy link
Member Author

Looks good to me. Is there anything else we need to do in order to push users over fromganache-cli?

We've already deprecated the package and pointed users here. Another issue is that the publisher of this package is a "truffle-cicd" without an avatar and it looks a bit strange. We've received feedback that the npm user doesn't look legitimate. An update for that is in the works.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly groundbreaking work. 🤯

@davidmurdoch davidmurdoch merged commit 5eb88fd into develop May 31, 2022
@davidmurdoch davidmurdoch deleted the add-keywords branch May 31, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ganache-core and ganache-cli to the ganache package's package.json keywords array.
3 participants