This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat: add version-checker to ganache startup #3285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add vX.x.x tag on release * merge master into develop after successful publish * add action to import TrufBot GPG keys for signed commits
…into feat/version-check
jeffsmale90
suggested changes
Dec 21, 2022
Co-authored-by: jeffsmale90 <[email protected]>
tenthirtyone
commented
Jan 12, 2023
Co-authored-by: jeffsmale90 <[email protected]>
jeffsmale90
suggested changes
Jan 31, 2023
| @@ -14,7 +14,7 @@ import type { VersionCheckOptions } from "./types"; | |||
| // Why is this not part of the config? Well, if a user | |||
| // set this to a low value there could be problems. | |||
| const ONE_DAY: number = 86400; | |||
|
|
|||
| const ACTIVATED = process.env.VC_ACTIVATED || false; | |||
There was a problem hiding this comment.
I'd prefer if the behaviour around process.env.VS_ACTIVATED was more obvious (ie the type of ACTIVATED is string | false).
Maybe something like
Suggested change
| const ACTIVATED = process.env.VC_ACTIVATED || false; | |
| const isActivated = process.env.VC_ACTIVATED === "true"; |
| // This file will eventually be replaced by another project. For now, we want to write to the | ||
| // future location in the namespace for VersionCheck. | ||
| // https://github.com/trufflesuite/ganache/pull/3285/files/0644054b8458eafdb52f2a9699842ed0c91f6a4e#r1068731549 | ||
| // Ive seen this crash when '/' is in the projectName, e.g. "Ganache/cli" but it seems ok if a file exists already. |
There was a problem hiding this comment.
Do we need to investigate this crash further?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the follow-on to #2859. The majority of code has already been reviewed and was merged when I slammed the green button home (wewps). The big change here is that the default config is set to opt-out so users will have to opt-in.
It might make sense to add a command line switch or easier way to toggle to opt-in. But once it's baked for a few weeks with the team opting in and any issues have been caught/corrected we'll slip the switch to opt-in by default.