Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: after provider.disconnect() is called, Ganache should stop serving requests #3433

Merged
merged 14 commits into from
Aug 19, 2022
Merged

fix: after provider.disconnect() is called, Ganache should stop serving requests #3433

merged 14 commits into from
Aug 19, 2022

Commits on Jul 27, 2022

  1. Reject all pending requests, and stop processing requets once provide… 

    …r.disconnect() is called.
    @jeffsmale90
    jeffsmale90 committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    0638bf6 View commit details
    Browse the repository at this point in the history

  2. Add the tests :/

    @jeffsmale90
    jeffsmale90 committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    ccafb7e View commit details
    Browse the repository at this point in the history

  3. Comments, and minor tidy up

    @jeffsmale90
    jeffsmale90 committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2528daa View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Await blockchain.stop before rejecting pending tasks,

    @jeffsmale90
    jeffsmale90 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b1327ed View commit details
    Browse the repository at this point in the history

  2. oops - still calling .getCoordinator(), even after removing it

    @jeffsmale90
    jeffsmale90 committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    e47d3ed View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. WIP - ensure that in progress tasks complete before stopping the bloc… 

    …kchain.
    @jeffsmale90
    jeffsmale90 committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    01d62f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Tidy up request-coordinator and add tests at EthereumProvider level

    @jeffsmale90
    jeffsmale90 committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    a59b00d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Revert a59b00d and 01d62f8

    @jeffsmale90
    jeffsmale90 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    51781af View commit details
    Browse the repository at this point in the history

  2. Best effort to settle tasks in order, added some tests

    @jeffsmale90
    jeffsmale90 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    942bacc View commit details
    Browse the repository at this point in the history

  3. Fix test to assert rejection order, tidy up

    @jeffsmale90
    jeffsmale90 committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    c0bd2f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. renames and tidy ups as per PR suggestions

    @jeffsmale90
    jeffsmale90 committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    392b843 View commit details
    Browse the repository at this point in the history

  2. Oops - paramsArg type mismatch

    @jeffsmale90
    jeffsmale90 committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    469b310 View commit details
    Browse the repository at this point in the history

  3. Revert finally change

    @jeffsmale90
    jeffsmale90 committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3f3b8dc View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Revert back to re-referencing queue() and resume() functions. Update … 

    …ConnectorLoader to _not_ maintain a reference to requestCoordinator.resume(), and test obscure edge case.
    @jeffsmale90
    jeffsmale90 committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    4dafd52 View commit details
    Browse the repository at this point in the history