fix: switch to user-provided logger rather than console.log

[MicaiahReid]

The Ganache options allow you to set a custom logger to handle any logging that Ganache does*. When using Ganache programatically, this can be done as follows:

const logger = {
  log: (message?: any, ...optionalParams: any[]) => {
    // whatever custom log stuff you want
  }
};

const provider = Ganache.provider({
  logging: { logger }
});

However, there were still a few hold-out console.logs in our code, which logged directly to the console rather than the user-provided log function. This change fixes this issue.

*Pro Tip: You can actually update that logger function while Ganache is running to temporarily change how you handle logs, if you're into that sort of thing.

[jeffsmale90]

In other places we console.warn().

should we consider extending the logger type to add some sort of log level awareness?

export type Logger = {
  log(message?: any, ...optionalParams: any[]): void;
  info(message?: any, ...optionalParams: any[]): void;
  warn(message?: any, ...optionalParams: any[]): void;
  error(message?: any, ...optionalParams: any[]): void;
};

When normalizing we could default info/warn/error back to log to avoid this being a breaking change.

[MicaiahReid]

I think it would be great to have a more robust logging system to do this, and I believe it's on the docket (though I couldn't find an issue for it). This PR was meant to just be a quick fix though, so I'd rather get this through. Especially because I hardly consider this a "warning" - there are no consequences to calling miner_start when the miner isn't paused, so what are we warning them against?

[jeffsmale90]

Although... it does start with the word "Warning:" 🦖

[jeffsmale90]

Can we require just the LoggingConfig here rather than the entire config object?

[MicaiahReid]

I'm glad you have an opinion because I kept going back and forth on this. Fixed.

Though the types here are a bit confusing - I think I got it right with EthereumInternalOptions["logging"] rather than LoggingConfig.