Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

chore: remove Promise.allSettled shim #4003

Merged
merged 6 commits into from
Dec 19, 2022
Merged

Conversation

tenthirtyone
Copy link
Contributor

This was TODO'd to be removed if we bumped typescript to 4.2.3+

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't think you needed to push the shrinkwrap for this one since no dependencies changed. I don't think it will hurt anything, though.

@@ -7,14 +7,6 @@ import {

import allSettled from "promise.allsettled";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promise.allsettled package itself should be removed.

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The promise.allsettled package itself should be removed.

@davidmurdoch
Copy link
Member

Looks like it doesn't work in Node v12.0.0. Let's wait on this until after the-merge is in

@davidmurdoch
Copy link
Member

@tenthirtyone let's merge this one after the merge is released (which should be later today).

Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. If you merge develop it'll kill off the node12 builds 🥳

@tenthirtyone
Copy link
Contributor Author

This all looks good to me. If you merge develop it'll kill off the node12 builds partying_face

@jeffsmale90 - should have been taken care of in 6268b36

@tenthirtyone tenthirtyone merged commit 788c656 into develop Dec 19, 2022
@tenthirtyone tenthirtyone deleted the chore/allsettled-shim branch December 19, 2022 16:52
@gitpoap-bot
Copy link

gitpoap-bot bot commented Dec 19, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 Ganache Contributor:

GitPOAP: 2022 Ganache Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants