This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: resolve hardfork for blocks by blocknumber and timestamp #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able, just fetch from the fork ¯\_(ツ)_/¯
…to instantiate a transaction in order to serialize it for the database. Except where we need the effective gas price for an eip-1559 fee market transaction, because we need to know the block basefeepergas :(
Deploying with
|
| Latest commit: |
8fd2a6c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8392f08b.ganache.pages.dev |
| Branch Preview URL: | https://fix-hardforkbytimestamp.ganache.pages.dev |
jeffsmale90
changed the title
jeffsmale90
changed the title
jeffsmale90
changed the title
jeffsmale90
changed the title
davidmurdoch
suggested changes
Jun 29, 2023
…ock' with some rewordering
davidmurdoch
approved these changes
Jun 30, 2023
This was referenced Dec 2, 2023
This was referenced Dec 12, 2023
This was referenced Dec 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Shanghai, hardforks are determined by timestamp, rather than block number. When resolving the hardfork to use for a given block, we now consider the blocknumber and the timestamp.
fixes: #4450 (in that the correct hardfork is now resolved, which is not
mergeForkIdTransition)See #4463