This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #336
This is a fairly trivial change, especially considering Ganache will never reorg and thus the
removed
property is moot (which reasonably explains its omission in the first place).However, for those of us who care whether or not a log was reorged as part of their application logic, and aren't using JavaScript (i.e., care about well-formed JSON-RPC responses and can't use the truthiness of
log.removed === undefined
), this lack ofremoved
renders Ganache unusable as a Web3 provider.