This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Ensure proper usage of yargs + npm create script with using --
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
commented
Jan 11, 2021
Comment on lines
-63
to
-64
| "Positionals:": chalk.bold("Options"), | ||
| "Options:": ` `, |
There was a problem hiding this comment.
I'm not sure why you insisted on joining these two while still having positional and non-positional arguments (from the way the script was written, despite they were all being processed as positional anyways). Regardless, if you have two separate types of arguments, they should be separated to help out developers understand what is what. By joining these, you're removing contextual help/usage information for a little extra screen space. I encourage you keep this if you choose this PR option.
mikeseese
changed the title
option options are properly processedcreate script with using --
|
Closing in favor of #707 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #700
See more details of why this PR is necessary in #704
This PR is option 2 (using named, non-positional args, but requiring
----
Because of the reasons stated in #704, if you want to use non-positional/named arguments in an NPM script, you must use the
--between thenpm run <script>and the first flag.This PR essentially re-introduces the changes I originally had in #701