This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
feat: add Filecoin.ChainNotify method and Filecoin support websockets and subscriptions
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeseese
force-pushed
the
feat/filecoin-chainnotify
branch
from
f2cffe9
to
9f88b4e
Compare
davidmurdoch
suggested changes
Jan 15, 2021
| // We have to use type any instead of ReturnType<typeof connector.parse> | ||
| // on `payload` because Typescript isn't smart enough to understand the | ||
| // ambiguity doesn't actually exist | ||
| let payload: any; |
There was a problem hiding this comment.
😢
Is the ambiguity caused by just having multiple chains? Or is it specific to the Filecoin API implementation?
There was a problem hiding this comment.
It's ambiguity caused by having multiple chains, not specific to Filecoin. It's likely that typescript is smart enough with some more convoluted types lol, but I didn't take the appropriate time to learn how to do the complex types yall have set up, because the current types do not support it. I personally don't think it's worth the time for this small functionality
mikeseese
commented
Jan 15, 2021
mikeseese
force-pushed
the
feat/add-filecoin-to-dynamic-cli
branch
from
8801d55
to
fabba07
Compare
mikeseese
force-pushed
the
feat/filecoin-chainnotify
branch
2 times, most recently
from
b8ec20f
to
ffcef74
Compare
mikeseese
force-pushed
the
feat/add-filecoin-to-dynamic-cli
branch
from
db1c5e8
to
482c72a
Compare
mikeseese
force-pushed
the
feat/filecoin-chainnotify
branch
from
ffcef74
to
d398425
Compare
mikeseese
force-pushed
the
feat/add-filecoin-to-dynamic-cli
branch
from
acec01f
to
50aa0aa
Compare
mikeseese
force-pushed
the
feat/filecoin-chainnotify
branch
from
d398425
to
86984ad
Compare
mikeseese
force-pushed
the
feat/filecoin-chainnotify
branch
from
86984ad
to
e4997b1
Compare
|
We're postponing these reviews until later |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #694 (although most Lotus applications want to use WebSockets)
This supports the Chain Explorer feature in the https://github.com/filecoin-shipyard/filecoin-network-inspector example
This PR also resolves #692: