This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Murdoch <[email protected]>
mikeseese
commented
Feb 4, 2021
"test": "nyc --reporter lcov npm run mocha", | ||
"mocha": "cross-env TS_NODE_COMPILER=ttypescript TS_NODE_FILES=true mocha --exit --check-leaks --throw-deprecation --trace-warnings --require ts-node/register --timeout 10000 'tests/**/*.test.ts'" | ||
"mocha": "cross-env TS_NODE_COMPILER=ttypescript TS_NODE_FILES=true ts-node ../../../../scripts/lerna-mocha.ts --require ts-node/register '_PACKAGEDIR_/tests/**/*.test.ts'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm closing this PR because @tcoulter wants PRs that have passing tests. Instead we are creating a PR with the next branch ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the work that was done in #726, but it includes more. Here's the full list of this PR's intention:
@ganache/filecoin
package as apeerDependency
for@ganache/flavors
and failing if the package cannot be foundlink.filecoin
script was added to the root package which is meant as a development helper to link the filecoin package for usagetsc.filecoin.declarations
to allow for quick ease and file cleaning viapretty-quick
@ganache/filecoin
. I originally intended to fix tests, but I found myself spending too much time fixing tests that were no longer fully applicable due to large overhauls in@ganache/filecoin/src/things
. I didn't want to spend much time getting the tests to pass in this state. You can see tests are passing in the subsequent branch. I strongly encourage we do not fixate on tests that are failing prior to this branch when this branch does not alter the behavior behind those tests.