fix(cli): enable SIGINT to shutdown cli on Windows #785

davidmurdoch · 2021-02-12T15:07:01Z

@seesemichaelj I liked the additional console.loggin you were outputting in one of your recent closed PRs, but didn't take time to find it. I'd appreciate your thoughts on these.

Here is normal graceful shutdown:

Chain Id
==================
1337

Listening on 127.0.0.1:8545
Received shutdown signal: SIGINT
Shutting down…
Server has been shut down
~\Documents\work\ganache-core-copy [fix/windows-sigint +0 ~2 -0 !]>

and if the user shuts down while ganache is starting:

Ganache CLI v0.1.0 (ganache-core: 0.1.0)
Starting RPC server
Received shutdown signal: SIGINT
Server is currently starting; waiting…
Shutting down…
Server has been shut down
~\Documents\work\ganache-core-copy [fix/windows-sigint +0 ~2 -0 !]>

Chain Id
==================
1337

Listening on 127.0.0.1:8545
Received shutdown signal: SIGINT
Shutting down…

Received an error while attempting to close the server: 
{an error}
~\Documents\work\ganache-core-copy [fix/windows-sigint +0 ~2 -0 !]>

src/packages/cli/src/cli.ts

src/packages/cli/index.ts

src/packages/cli/src/cli.ts

src/packages/core/index.ts

src/packages/cli/src/cli.ts

Co-authored-by: Mike Seese <[email protected]>

fix(cli): enable SIGINT to shutdown cli on Windows

6205481

davidmurdoch requested a review from mikeseese February 12, 2021 15:07

davidmurdoch commented Feb 12, 2021

View reviewed changes

davidmurdoch marked this pull request as ready for review February 12, 2021 15:32

mikeseese suggested changes Feb 12, 2021

View reviewed changes

src/packages/cli/src/cli.ts Outdated Show resolved Hide resolved

src/packages/cli/src/cli.ts Show resolved Hide resolved

src/packages/cli/src/cli.ts Show resolved Hide resolved

Update src/packages/cli/src/cli.ts

910a71c

Co-authored-by: Mike Seese <[email protected]>

davidmurdoch requested a review from mikeseese February 12, 2021 21:05

mikeseese approved these changes Feb 12, 2021

View reviewed changes

davidmurdoch merged commit 35c7e41 into develop Feb 12, 2021

davidmurdoch deleted the fix/windows-sigint branch February 12, 2021 21:17

sambacha pushed a commit to contractshark/ganache-core that referenced this pull request Apr 15, 2021

fix(cli): enable SIGINT to shutdown cli on Windows (trufflesuite#785)

67c22f4

Co-authored-by: Mike Seese <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): enable SIGINT to shutdown cli on Windows #785

fix(cli): enable SIGINT to shutdown cli on Windows #785

davidmurdoch commented Feb 12, 2021

fix(cli): enable SIGINT to shutdown cli on Windows #785

fix(cli): enable SIGINT to shutdown cli on Windows #785

Conversation

davidmurdoch commented Feb 12, 2021