This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: support a uws fallback if uws native binaries don't exist (win+electron) #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
approved these changes
Apr 2, 2021
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 14, 2021
* chore: point community link at our discord channel (trufflesuite#874) * chore(deps): bump y18n from 4.0.0 to 4.0.1 (trufflesuite#884) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: rearchitect server status and move async functions from constructors to initialize functions (trufflesuite#877) * feat: add filecoin flavor (trufflesuite#888) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]> * fix: support a uws fallback if uws native binaries don't exist (win+electron) (trufflesuite#893) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Seese <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]>
sambacha
pushed a commit
to contractshark/ganache-core
that referenced
this pull request
Apr 15, 2021
* chore: point community link at our discord channel (trufflesuite#874) * chore(deps): bump y18n from 4.0.0 to 4.0.1 (trufflesuite#884) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: rearchitect server status and move async functions from constructors to initialize functions (trufflesuite#877) * feat: add filecoin flavor (trufflesuite#888) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]> * fix: support a uws fallback if uws native binaries don't exist (win+electron) (trufflesuite#893) Co-authored-by: David Murdoch <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Seese <[email protected]> Co-authored-by: David Murdoch <[email protected]> Co-authored-by: Tim Coulter <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
@trufflesuite/uws-js-unofficial, which changes were made to implement a fallback/shim/polyfill if native binaries don't exist. We also removed binaries for windows+electron since that doesn't work currently.This PR also updates
ethereum/src/connector.tsto account for the new constructor name for the polyfill.This PR also bumps versions for a release.