This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 683
Create Transaction Factory and Introduce EIP2930 Access List Transactions #943
Merged
Merged
Changes from all commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
43ffb2e
add tx type 1
MicaiahReid 5f49acd
fix debug.test.ts compilation error
davidmurdoch 1338a4a
rename raw and accesslist tx types
MicaiahReid c6a2a83
improve error message
MicaiahReid 613e15d
remove todos
MicaiahReid c6d48b2
cleanup unusable code paths
MicaiahReid 8b7df43
add typed transaction test cases for eth api
MicaiahReid 9e02684
add transaction factory tests
MicaiahReid 7c5d84d
remove unused imports
MicaiahReid c955544
fix transaction tests
MicaiahReid 18fadd2
add tx type 1
MicaiahReid d9d9a12
fix debug.test.ts compilation error
davidmurdoch 5c03891
rename raw and accesslist tx types
MicaiahReid 8eb41d9
improve error message
MicaiahReid 9206e99
remove todos
MicaiahReid 603b599
cleanup unusable code paths
MicaiahReid f0b6a99
add typed transaction test cases for eth api
MicaiahReid 455da2d
add transaction factory tests
MicaiahReid 8c605b5
remove unused imports
MicaiahReid 493fe51
fix transaction tests
MicaiahReid 11b9d0b
Merge branch 'tx-types7' of github.com:trufflesuite/ganache-core into…
MicaiahReid 4f2137c
cleaning up
MicaiahReid 386c960
clean up. improve check for tx type
MicaiahReid 63d44b7
clean import path
MicaiahReid c5d9822
more cleanup of unused logic paths
MicaiahReid 6d689ed
reformat factory. check eips for each tx type
MicaiahReid 7d51c98
remove redundant test
MicaiahReid 1dab284
negative test cases for tx types pre berlin
MicaiahReid 0a56607
only return legacy tx type if EIP2718 is activated
MicaiahReid daa2b4e
converts typed txs to legacy pre eip2718
MicaiahReid ded7c00
fix path for import
MicaiahReid 7c34b72
fix issue with fetching block txs
MicaiahReid c307878
fix issue with validating signature of typed txs
MicaiahReid fe6a3a1
add forking test
MicaiahReid af40a69
reformat factory. check eips for each tx type
MicaiahReid f967903
remove redundant test
MicaiahReid b5a59a7
negative test cases for tx types pre berlin
MicaiahReid f02b324
only return legacy tx type if EIP2718 is activated
MicaiahReid c543d3d
converts typed txs to legacy pre eip2718
MicaiahReid 5fc8b66
Merge branch 'feat/tx-factory-eip-check' of github.com:trufflesuite/g…
MicaiahReid ab30325
Apply suggestions from code review
MicaiahReid 945002c
remove unused imports
MicaiahReid 3470a5f
cleanup unused JSDOC notes
MicaiahReid b94fd3e
Merge branch 'tx-types7' of github.com:trufflesuite/ganache-core into…
MicaiahReid b1f1fa3
add type for all eip capabilities
MicaiahReid eb45fcb
reformat factory. check eips for each tx type
MicaiahReid 01b4052
remove redundant test
MicaiahReid 7580f85
negative test cases for tx types pre berlin
MicaiahReid 8f26baf
only return legacy tx type if EIP2718 is activated
MicaiahReid 4734180
converts typed txs to legacy pre eip2718
MicaiahReid bd04674
check activated eips on receipt retreival
MicaiahReid d194539
Merge branch 'feat/tx-factory-eip-check' of github.com:trufflesuite/g…
MicaiahReid e7ade05
stripping type away from legacy tx
MicaiahReid 652cc47
remove unused export
MicaiahReid 8f9ae8a
remove unused references
MicaiahReid b576eae
removed unused imports
MicaiahReid 46aa9aa
optimize eip2930 data fee calculation
MicaiahReid e218110
use eip2930 data fee calculation
MicaiahReid ca63504
use coded errors in tx factory
MicaiahReid b4b0f92
use our own lib for data conversions
MicaiahReid 1454d04
make expected values in tests the same every time
MicaiahReid 0dd866b
let to const
MicaiahReid b248899
removing frozen/fake tx and resolving side effects
MicaiahReid c43297b
add comment
MicaiahReid d134856
fix capability check
MicaiahReid d0d18a7
remove reference to fake-transaction
MicaiahReid 304dd21
fix typo
MicaiahReid 3796cb9
replace RuntimeTransaction usage with TypedTransaction
MicaiahReid 32577db
Merge branch 'develop' into tx-types7
davidmurdoch e9e09b3
make the tests work!
davidmurdoch 808f6be
Merge branch 'tx-types7' of github.com:trufflesuite/ganache into tx-t…
davidmurdoch aad4b01
fix some failing tests that don't have anything to do with the rest o…
davidmurdoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export * from "./src/block"; | ||
export * from "./src/runtime-block"; | ||
export * from "./src/snapshots"; | ||
export * from "./src/serialize"; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I can see the need to add this field. Maybe this is something the VM requires now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the new version of ethereumjs-vm needs this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. We set it to the parent's gasUsed in some cases, which seems odd to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've seen, we do that whenever we're trying to simulate a transaction or estimate gas. We can discuss, but I'm pretty sure the cases where it's set to the parent's gasUsed makes sense.