This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Test Web3.js 1.0 release by adding yarn link step to Travis install
#2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤞 |
|
(Must also double check that we don't need to do a rebuild post linking) |
CruzMolina
reviewed
Jul 12, 2019
|
scrypt!!! |
This reverts commit 976f101.
gnidan
commented
Jul 12, 2019
| @@ -97,7 +96,7 @@ export namespace Contexts { | |||
| debug("signature read: %s", signature); | |||
| //if not, compute it ourselves | |||
| if(signature === undefined) { | |||
| signature = abiCoder.encodeFunctionSignature(<AbiItem>abiEntry); | |||
| signature = abiCoder.encodeFunctionSignature(<any>abiEntry); | |||
There was a problem hiding this comment.
Doing this since #2214 demonstrates the same AbiItem failure as on this branch, and I think this shouldn't impact the web3 release validation.
|
We're green! This PR uses yalc to inject locally-built web3.js from the I think we can confidently sign off on web3/web3.js#2905! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To validate web3/web3.js#2905