Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add lazy-require for command dependencies #355

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Add lazy-require for command dependencies #355

merged 1 commit into from
Feb 10, 2017

Conversation

LogvinovLeon
Copy link
Contributor

@LogvinovLeon LogvinovLeon commented Feb 9, 2017 •
edited
Loading

This solves first part of #343.
I described an issue in detail there.

@fabioberger
Copy link
Contributor

Wow! Nice, I tested this out locally and got a similarly impressive bump in the speed:

$ time truffle version
Truffle v3.1.1

real	0m0.445s
user	0m0.304s
sys	0m0.064s

@tcoulter
Copy link
Contributor

tcoulter commented Feb 9, 2017

Thanks for doing this. Lazy-require isn't my favorite stylistically, but here it's obviously the way to go. Thanks for the PR!

@tcoulter tcoulter merged commit f98178a into trufflesuite:master Feb 10, 2017
@tcoulter
Copy link
Contributor

This has been merged. Really appreciate the contribution.

@LogvinovLeon LogvinovLeon deleted the lazy-require-commands-deps branch February 10, 2017 07:59
@tcoulter tcoulter mentioned this pull request Feb 10, 2017
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LogvinovLeon @fabioberger @tcoulter