Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Hook up example events -> dashboard communication #4923

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Mar 23, 2022

This PR does a few things:

  • Add a new "debug" message type, intended for logging in the browser console. This message type behaves like "provider" messages, in that it waits for a response from a subscriber.
  • Handle this new message type in the frontend by logging and then issuing a blank response to clear it from the message-bus requests queue
  • Initialize a quick DashboardMessageBusClient for use in @truffle/events. Define a sendAndAwait method to behave similarly to the @truffle/dashboard-message-bus util function
  • Use this client to send an example debug message to the browser upon "compile:start"

Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and quick. I like things that unblock.

@gnidan
Copy link
Contributor Author

gnidan commented Mar 23, 2022

Thanks for the fix @benjamincburns... your changes look good to me, so I think we can merge this!

@gnidan gnidan merged commit ac2f6c4 into dash Mar 23, 2022
@gnidan gnidan deleted the dashboard/events branch March 23, 2022 06:13
MicaiahReid pushed a commit that referenced this pull request Mar 24, 2022
Hook up example events -> dashboard communication
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants