This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Remove unused @truffle/dashboard-provider module
#5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincburns
force-pushed
the
remove-dashboard-provider
branch
2 times, most recently
from
0c8dac0
to
048c93f
Compare
cds-amal
approved these changes
Apr 21, 2022
|
|
||
| ### Adding new message types | ||
|
|
||
| Right now there are very few message types. The most important one is `"provider"`, which sends RPC requests for the dashboard-provider. Other message types are `"invalidate"`, which can be sent to invalidate earlier messages, and `"log"`, which is sent by the message bus to send log messages over the wire. The interfaces of these messages are defined inside the `@truffle/dashboard-message-bus` package, from where they can be imported by consumers. | ||
| Right now there are very few message types. The most important one is `"provider"`, which sends RPC requests to the `@truffle/dashboard` so that they can be handled by the injected web3 provider that your wallet (e.g. MetaMask) provides. Other message types are `"invalidate"`, which can be sent to invalidate earlier messages, and `"log"`, which is sent by the message bus to send log messages over the wire. The interfaces of these messages are defined inside the `@truffle/dashboard-message-bus` package, from where they can be imported by consumers. |
There was a problem hiding this comment.
Not for this PR, but we should document the message types, or add the current links that do.
benjamincburns
force-pushed
the
remove-dashboard-provider
branch
from
048c93f
to
0c75162
Compare
|
Note: This will incidentally address #5034. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.