This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Prevent fetch-and-compile tests from hitting the network #5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
requested review from
gnidan,
benjamincburns,
cds-amal,
sukanyaparashar,
leeftk and
cliffoo
gnidan
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, uh, some of our fetch-and-compile tests were accidentally hitting the real network for their sources. Oops! >_> This is due to me messing up the URLs in the test fixtures. I fixed the URLs and now the tests don't hit the network anymore (tested by running the tests with internet turned off).
(Why not obviate this problem by preventing the tests from hitting the real network at all, rather than just the specified URLs? Because when you do that, they fail to fetch solc...)