This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Simplify contract-sources's default export #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
previously approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Makes sense to me, I dunno why this needs to be async. Wondering if @gnidan has an opinion.
|
probably worth keeping as |
haltman-at
dismissed
their stale review
Gonna dismiss my approval for now since maybe this should be async?
|
Ok I'll leave it |
eggplantzzz
force-pushed
the
simplify-cs
branch
3 times, most recently
from
3a84357
to
c379823
Compare
haltman-at
approved these changes
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE FOR contract-sources
This removes the callback from the default export's signature.